Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gci and avoid deprecated packages #388

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 18, 2023

This PR adds GCI to okp4d

It'll now have very neatly -- deterministically --
ordered imports.

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #388 (2f71f14) into main (7bf9a42) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          60       60           
  Lines        2633     2633           
=======================================
  Hits         1681     1681           
  Misses        873      873           
  Partials       79       79           
Impacted Files Coverage Δ
x/logic/fs/wasm.go 87.17% <ø> (ø)
x/logic/keeper/grpc_query_ask.go 53.12% <0.00%> (ø)
x/logic/keeper/grpc_query_params.go 57.14% <ø> (ø)
x/logic/keeper/keeper.go 64.70% <ø> (ø)
x/logic/keeper/migrations.go 0.00% <ø> (ø)
x/logic/keeper/msg_server.go 75.00% <ø> (ø)
x/logic/keeper/params.go 52.63% <ø> (ø)
x/logic/predicate/address.go 87.23% <ø> (ø)
x/logic/predicate/bank.go 89.74% <ø> (ø)
x/logic/predicate/crypto.go 77.27% <ø> (ø)
... and 23 more

Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll be helpful, thanks :)

Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks 👍

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! ♥️

@amimart amimart merged commit f0d8b3e into axone-protocol:main Jun 19, 2023
@bot-anik
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants