-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧠 Logic: 📪 bech32_address/2
predicate
#297
Conversation
bech32_address/3
predicatebech32_address/3
predicate
bech32_address/3
predicatebech32_address/2
predicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is quite good! Thanks for the job.
However, I have a few concerns about the error messages, their consistency (especially in relation to other predicates), and their formalization. But I think we can address this in a second step.
It would also be helpful to provide a thorough description of this predicate, as the generated documentation will be very useful for understanding the predicates supported by the module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 💪
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implement #295 :
📝 Purpose
In the
logic
module, purpose an utility function to manipulate bech32 address.🧪 Expected behavior
bech32_address/2
is a predicate that convert a bech32 encoded string into base64 bytes and give the address prefix or convert a prefix and base64 encoded bytes to bech32 encoded string. The signature is as follow:Where:
Address
is a pair containing HRP (Human-Readable Part) containing the address prefix and the list of integers between 0 and 255 (byte) that represent the base64 encoded bech32 address string. Represented like this :-(HRP, Address)
Bech32
is an Atom or string representing the bech32 encoded string address🎯 Example
Give :