Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe attachment access, fixing #140 #144

Closed

Conversation

Blackoverflow
Copy link
Collaborator

Hi Nanu-c,

this is a fix for #140, denying access to resources outside the attachment directory.
It still uses the full file path as parameter.

Regards

Blackoverflow

@Flaburgan
Copy link
Collaborator

I'm not sure that really solve #140. Indeed, /etc will not be accessible anymore, but that's only part of the problem. In my opinion, the point is that other applications can access files in the filesystem by requesting the /attachment route (that's already a problem) and that even without the user noticing it. IMO we need some kind of token between the front and the back to only allow axolotl front end to access those routes.

@Blackoverflow
Copy link
Collaborator Author

Yes, your are right. This fix just alleviates the problem, but the app needs a mechanism to prevent unauthorized access through the browser.

@nanu-c nanu-c closed this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants