Fix broken CLI; remove duplicate metadata from setup.py #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
approved these changes
Dec 6, 2024
winglian
reviewed
Dec 6, 2024
|
I canceled the e2e tests on this as they are not necessary for this PR |
3 tasks
djsaunde
added a commit
that referenced
this pull request
Dec 16, 2024
* Fix broken CLI; remove duplicate metadata from setup.py * Adding tests.yml CLI check * updating * remove test with requests to github due to rate limiting --------- Co-authored-by: Dan Saunders <[email protected]>
djsaunde
added a commit
that referenced
this pull request
Dec 17, 2024
* Fix broken CLI; remove duplicate metadata from setup.py * Adding tests.yml CLI check * updating * remove test with requests to github due to rate limiting --------- Co-authored-by: Dan Saunders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title. Recent
pyproject.tomladdition clashes with the CLI PR changes. Fixed by specifiying the entry point inpyproject.toml. I was also able to remove some duplicate metadata insetup.py.Motivation and Context
CLI is broken.
How has this been tested?
On this branch: