Fix duplication of plugin callbacks #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiragjn
force-pushed
the
cj_fix_duplicate_callbacks
branch
from
0e09374 to
b125f89
Compare
|
Thanks. I think this was likely a merge issue when I rebased that PR and we were both simultaneously adding that functionality. Great catch. |
winglian
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1917 Added code to call the plugin manager to get the callbacks at the end of
HFCausalTrainerBuilder.get_post_trainer_create_callbacks, however the plugins were already being added via asuper().get_post_trainer_create_callbackscall. This has caused the plugin callbacks to be duplicated. This PR fixes it by moving the super call at the endHow has this been tested?
Manually
Screenshots (if appropriate)
Types of changes
N/A
Social Handles (Optional)
N/A