Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQS.md #186

Merged
merged 4 commits into from
Jun 11, 2023
Merged

Update FAQS.md #186

merged 4 commits into from
Jun 11, 2023

Conversation

akj2018
Copy link
Contributor

@akj2018 akj2018 commented Jun 11, 2023

Updated FAQS.md with the following statement

Error invalid argument at line 359 in file /workspace/bitsandbytes/csrc/pythonInterface.c /arrow/cpp/src/arrow/filesystem/s3fs.cc:2598: arrow::fs::FinalizeS3 was not called even though S3 was initialized. This could lead to a segmentation fault at exit

try reinstalling bitsandbytes and transformers from source

Update FAQS.md with the following statement

Error invalid argument at line 359 in file /workspace/bitsandbytes/csrc/pythonInterface.c
/arrow/cpp/src/arrow/filesystem/s3fs.cc:2598:  arrow::fs::FinalizeS3 was not called even though S3 was initialized.  This could lead to a segmentation fault at exit

try reinstalling bitsandbytes and transformers from source
@NanoCode012
Copy link
Collaborator

Hi, thanks for the PR! Would it be possible to add backticks ``` around the error for easier viewing?

Updated FAQS.md with backticks around error message
Copy link
Collaborator

@NanoCode012 NanoCode012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the fix. Since you want to do inline, my previous comment was not right. I apologize for that. I think a single backtick is enough.

FAQS.md Outdated
@@ -2,3 +2,6 @@

- Can you train StableLM with this? Yes, but only with a single GPU atm. Multi GPU support is coming soon! Just waiting on this [PR](https://github.com/huggingface/transformers/pull/22874)
- Will this work with Deepspeed? That's still a WIP, but setting `export ACCELERATE_USE_DEEPSPEED=true` should work in some cases
- ```Error invalid argument at line 359 in file /workspace/bitsandbytes/csrc/pythonInterface.c```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ```Error invalid argument at line 359 in file /workspace/bitsandbytes/csrc/pythonInterface.c```
- `Error invalid argument at line 359 in file /workspace/bitsandbytes/csrc/pythonInterface.c`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot this one :)

FAQS.md Outdated Show resolved Hide resolved
Co-authored-by: NanoCode012 <[email protected]>
@akj2018
Copy link
Contributor Author

akj2018 commented Jun 11, 2023

Is there any further change required ? I can still see changes requested option. Sorry for the stupid questions. I just started my open source journey.

Converted (```) to single backtick (') uniformly.
@NanoCode012 NanoCode012 merged commit e944311 into axolotl-ai-cloud:main Jun 11, 2023
@NanoCode012
Copy link
Collaborator

Thank you for the PR! I'm sorry for the little bits back and forth. It's a nice start :)

@winglian winglian mentioned this pull request Jun 12, 2023
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants