Add syslog ng visibility into perf stackdumps #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
add-syslog-ng-visibility-into-perf-stackdumps
branch
2 times, most recently
from
1f0d5ce to
24d825c
Compare
bazsi
force-pushed
the
add-syslog-ng-visibility-into-perf-stackdumps
branch
from
24d825c to
0d7227a
Compare
bazsi
changed the title
bazsi
force-pushed
the
add-syslog-ng-visibility-into-perf-stackdumps
branch
8 times, most recently
from
f5d90b6 to
a2f964b
Compare
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
These were originally optional methods, but that means that descendant classes will not call the one from LogPipe. Let's create that so we have a spot to initialize perf trampolines. Signed-off-by: Balazs Scheidler <[email protected]>
When extracting the source text, we need to split the input into lines. Previously this was done every time we extracted a line of text, causing the startup to be very slow when I enabled source extraction for every FilterXExpr instance. This patch causes the result of that g_strsplit() call to be saved, effectively using more memory startup, but being a lot more efficient (e.g. startup within a second instead of 20 seconds or so). Signed-off-by: Balazs Scheidler <[email protected]>
In case an expr is optimized we might be setting the location of exprs multiple times, prepare for this case by freeing expr_text before setting it first. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
add-syslog-ng-visibility-into-perf-stackdumps
branch
from
a2f964b to
73157be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds filterx expr and logpipe level detail into perf backtraces. It depends on #444