-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grpc service accounts #412
base: main
Are you sure you want to change the base?
Conversation
This Pull Request introduces config grammar changesaxoflow/62228cd45e7744ded91a839c6893c8b2835c50f5 -> sodomelle/grpc-service-accounts --- a/destination
+++ b/destination
axosyslog-otlp(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
bigquery(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
clickhouse(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
google-pubsub-grpc(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
loki(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
opentelemetry(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
syslog-ng-otlp(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
|
Signed-off-by: Tamás Kosztyu <[email protected]>
0c88974
to
b17f698
Compare
Signed-off-by: Tamás Kosztyu <[email protected]>
b17f698
to
0ef5c9e
Compare
Signed-off-by: Tamás Kosztyu <[email protected]>
0ef5c9e
to
7c6842f
Compare
Signed-off-by: Tamás Kosztyu <[email protected]>
7c6842f
to
07df96e
Compare
Signed-off-by: Tamás Kosztyu <[email protected]>
07df96e
to
8cdcc06
Compare
Signed-off-by: Tamás Kosztyu <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]>
Signed-off-by: Tamás Kosztyu <[email protected]>
8cdcc06
to
d808a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor news entry related comments, otherwise approve!
}; | ||
``` | ||
|
||
Note: It seems like gRPC sets the audience and scope options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be more direct with this, something like:
Note: In contrary to the `http()` destination's similar option,
we do not need to manually set the audience here as it is
automatically recognized by the underlying gRPC API.
@@ -0,0 +1,15 @@ | |||
grpc: Added service account option for grpc destinations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's name all the relevant destinations:
bigquery()
, google-pubsub-grpc()
: Added service-account()
authentication option.
It seems like gRPC sets the audience and scope options based on the gRPC service name, so they can't be set in the config.
Example usage: