Filterx regexp_search rework #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshifter
force-pushed
the
filterx-regexp-search
branch
3 times, most recently
from
968c9d0 to
355d819
Compare
Merged
alltilla
previously approved these changes
Dec 3, 2024
bshifter
dismissed
alltilla’s stale review
The merge-base changed after approval.
add macro to define flag_names Signed-off-by: shifter <[email protected]>
Introduced two new optional flags: keep_zero and list_mode. The result type no longer switches between dict and list based on the presence of named groups. The default result type is now dict. list_mode can force a list result, either via the flag or the type of the fillable (the fillable's type takes precedence). Match group zero is now excluded by default unless no other groups are present. This behavior can be overridden using the keep_zero flag. Additionally, the FilterXRematchState structure, shared across other regexp functions, has been updated with a generic flags field. This allows functions to pass custom options to the state without incurring additional overhead. Signed-off-by: shifter <[email protected]>
…rade Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
bshifter
force-pushed
the
filterx-regexp-search
branch
from
355d819 to
ff6d70d
Compare
alltilla
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #394
based on #392
Introduced two new optional flags: keep_zero and list_mode.
The result type no longer switches between dict and list based on the presence of named groups.
The default result type is now dict.
list_mode can force a list result, either via the flag or the type of the fillable (the fillable's type takes precedence).
Match group zero is now excluded by default unless no other groups are present. This behavior can be overridden using the keep_zero flag.
Additionally, the FilterXRematchState structure, shared across other regexp functions, has been updated with a generic flags field. This allows functions to pass custom options to the state without incurring additional overhead.