Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for install-receipts from sh #776

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Feb 6, 2024

fixes #773

@Gankra Gankra force-pushed the add-receipt-tests branch 9 times, most recently from c624c72 to 240433d Compare February 6, 2024 06:24
@Gankra
Copy link
Contributor Author

Gankra commented Feb 6, 2024

TODO:

  • check if we really want ~/.cargo/ and not ~/.cargo/bin/ in the install receipt
  • pick a "good" seperator for the sed (currently stubbed to ~) ((or better escaping?))

@Gankra Gankra force-pushed the add-receipt-tests branch from 240433d to 3946b24 Compare February 8, 2024 20:20
@Gankra Gankra force-pushed the add-receipt-tests branch from 3946b24 to cf36b72 Compare February 8, 2024 21:34
@Gankra Gankra merged commit e0d4cb1 into main Feb 8, 2024
15 checks passed
@Gankra Gankra deleted the add-receipt-tests branch February 8, 2024 22:06
@mistydemeo
Copy link
Contributor

check if we really want ~/.cargo/ and not ~/.cargo/bin/ in the install receipt

We do, yes. While we're likely to only install binaries, in the future we'll be installing other kinds of files - libraries, config files, etc. These are installed in other subdirectories inside the install prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sed error in install script
2 participants