all:Remove trie cache journal period #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco4203
approved these changes
Oct 4, 2024
Francesco4203
pushed a commit
that referenced
this pull request
Oct 17, 2024
huyngopt1994
added a commit
that referenced
this pull request
Oct 25, 2024
huyngopt1994
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the trie cache journal logic
We will have logic for flushing the clean trie cache to disk (triecache) periodcally and load it into triedatabase as warmup when the node starting for enhancing the performance in query
The cache will be updated in 2 logics
This removing will be trade off between a sightly decrease in performance and robutness
E.g. https://github.com/ethereum/go-ethereum/blob/master/core/blockchain.go#L649
we may stop at the incomplete state in repair procedure if the root node is found in
clean cache.
ethereum/go-ethereum#27525 (comment) Benchmarking performance, 99.99 wil be impacted but not too much.