Add reserved gas for system transactions #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh-1
approved these changes
Nov 30, 2022
minh-bq
force-pushed
the
feat/gas-reserve
branch
from
fce1da2 to
1c8c44a
Compare
| @@ -813,6 +819,12 @@ func (w *worker) commitTransactions(txs *types.TransactionsByPriceAndNonce, coin | |||
| gasLimit := w.current.header.GasLimit | |||
| if w.current.gasPool == nil { | |||
| w.current.gasPool = new(core.GasPool).AddGas(gasLimit) | |||
|
|
|||
| // If the gas pool is newly created, reserve some gas for system transactions | |||
| if err := w.current.gasPool.SubGas(w.config.GasReserve); err != nil { | |||
There was a problem hiding this comment.
you are in pessimistic mode
Currently, when collecting transactions to commit to a block, we only check the accumulated gas with block's gas limit. Later, when finalizing the block, with system transactions included, the block's gas used may exceed the block's gas limit. As a result, that block is not mined. We want to avoid this scenario by introducing a new flag to reserve some gas in gas pool for system transactions.
minh-bq
force-pushed
the
feat/gas-reserve
branch
from
1c8c44a to
3a58f98
Compare
minh-bq
added a commit
to minh-bq/ronin
that referenced
this pull request
Oct 4, 2023
This partially reverts commit a1f3645 to make the reserved gas a constant not a provided configuration from user. This still keeps the created flag in that commit for compatibility.
minh-bq
added a commit
that referenced
this pull request
Oct 4, 2023
) * Revert "Add reserved gas for system transactions (#187)" This partially reverts commit a1f3645 to make the reserved gas a constant not a provided configuration from user. This still keeps the created flag in that commit for compatibility. * miner, txpool: add a reserved gas constant for system transactions This commit adds the reserved gas for system transaction, which is previously a user provided flag, as a constant. In the miner part, the miner stops commit normal transactions to block when block gas used is over the block's gas limit - reserved gas. So when finalizing and including system transactions into block, the block's gas used does not exceed the block's gas limit. In the txpool part, when validating a transaction before putting it into the pool, previously, we only check if the transaction's gas limit is not over the block's gas limit. However, if the transaction's gas limit is over the block's gas limit - reserved gas, it is never included into the block but still always stay in pending transaction pool. This commit fixes the check to reject the transaction with gas limit over the block's gas limit - reserved gas.
minh-bq
added a commit
that referenced
this pull request
Oct 4, 2023
) * Revert "Add reserved gas for system transactions (#187)" This partially reverts commit a1f3645 to make the reserved gas a constant not a provided configuration from user. This still keeps the created flag in that commit for compatibility. * miner, txpool: add a reserved gas constant for system transactions This commit adds the reserved gas for system transaction, which is previously a user provided flag, as a constant. In the miner part, the miner stops commit normal transactions to block when block gas used is over the block's gas limit - reserved gas. So when finalizing and including system transactions into block, the block's gas used does not exceed the block's gas limit. In the txpool part, when validating a transaction before putting it into the pool, previously, we only check if the transaction's gas limit is not over the block's gas limit. However, if the transaction's gas limit is over the block's gas limit - reserved gas, it is never included into the block but still always stay in pending transaction pool. This commit fixes the check to reject the transaction with gas limit over the block's gas limit - reserved gas.
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
…xieinfinity#364) * Revert "Add reserved gas for system transactions (axieinfinity#187)" This partially reverts commit a1f3645 to make the reserved gas a constant not a provided configuration from user. This still keeps the created flag in that commit for compatibility. * miner, txpool: add a reserved gas constant for system transactions This commit adds the reserved gas for system transaction, which is previously a user provided flag, as a constant. In the miner part, the miner stops commit normal transactions to block when block gas used is over the block's gas limit - reserved gas. So when finalizing and including system transactions into block, the block's gas used does not exceed the block's gas limit. In the txpool part, when validating a transaction before putting it into the pool, previously, we only check if the transaction's gas limit is not over the block's gas limit. However, if the transaction's gas limit is over the block's gas limit - reserved gas, it is never included into the block but still always stay in pending transaction pool. This commit fixes the check to reject the transaction with gas limit over the block's gas limit - reserved gas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when collecting transactions to commit to a block, we only check the accumulated gas with block's gas limit. Later, when finalizing the block, with system transactions included, the block's gas used may exceed the block's gas limit. As a result, that block is not mined. We want to avoid this scenario by introducing a new flag to reserve some gas in gas pool for system transactions.