protocols/ronin, vote/votepool: improve vote channel queue (#336)

* protocols/ronin: remove redudant finality vote channel put * vote/vote_pool: make PutVote non-blocking, drop vote in case of failure
axieinfinity · Sep 7, 2023 · e2e7ed3 · e2e7ed3
1 parent 368fe23
commit e2e7ed3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/core/vote/vote_pool.go b/core/vote/vote_pool.go
@@ -120,7 +120,11 @@ func (pool *VotePool) loop() {
 }
 
 func (pool *VotePool) PutVote(peer string, vote *types.VoteEnvelope) {
-	pool.votesCh <- &voteWithPeer{vote: vote, peer: peer}
+	select {
+	case pool.votesCh <- &voteWithPeer{vote: vote, peer: peer}:
+	default:
+		log.Debug("Failed to put vote into vote pool")
+	}
 }
 
 func (pool *VotePool) putIntoVotePool(voteWithPeerInfo *voteWithPeer) bool {

diff --git a/eth/protocols/ronin/peer.go b/eth/protocols/ronin/peer.go
@@ -89,7 +89,6 @@ func (p *Peer) AsyncSendNewVote(vote *types.VoteEnvelope) {
 	default:
 		p.Log().Debug("Dropping vote announcement", "hash", vote.Hash())
 	}
-	p.voteCh <- vote
 }
 
 // batchVote batches multiple votes and sends to the peer.