-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default estimator type #37
Comments
Additionally, a missing or bad Likely the best course is to check availability of params.estimator and throw a proper error message if the property is missing. |
Additionally, there is a bug in the default switch case of the The bug can be seen in the error message:
The correct error message should be |
Current
nudged.estimate
throws an error ifestimator
property is not defined.This could be improved by:
TSR
, if the property is not defined.However, this change can introduce hard-to-detect bugs if the user wrongly remembers or types the property name. For example if the user writes
type: 'TS'
orestimate: 'TS'
instead ofestimator: 'TS'
then the bug will be found only after an unexpected multi-pointer rotation occurs.The text was updated successfully, but these errors were encountered: