Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minor): rename id field in CrosschainId to message_id #538

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

cgorenflo
Copy link
Contributor

No description provided.

@cgorenflo cgorenflo requested a review from a team as a code owner July 24, 2024 01:24
@cgorenflo
Copy link
Contributor Author

todo: migrate data that has a crosschain id in it

@cgorenflo cgorenflo marked this pull request as draft July 24, 2024 03:32
# Conflicts:
#	contracts/gateway/tests/test_verify.json
@cgorenflo cgorenflo marked this pull request as ready for review July 24, 2024 22:37
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 99.24242% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.12%. Comparing base (3359fc3) to head (5f07410).

Files Patch % Lines
contracts/gateway/src/contract.rs 0.00% 1 Missing ⚠️
packages/router-api/src/primitives.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   94.07%   94.12%   +0.05%     
==========================================
  Files         185      186       +1     
  Lines       25904    26110     +206     
==========================================
+ Hits        24368    24577     +209     
+ Misses       1536     1533       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/router-api/src/primitives.rs Outdated Show resolved Hide resolved
contracts/gateway/src/contract/migrations/v0_2_3.rs Outdated Show resolved Hide resolved
# Conflicts:
#	packages/router-api/src/primitives.rs
@cgorenflo cgorenflo merged commit 770a488 into main Jul 26, 2024
6 checks passed
@cgorenflo cgorenflo deleted the ccid-field-change branch July 26, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants