-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(ampd): build ampd in gh actions #533
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
=======================================
Coverage 94.07% 94.07%
=======================================
Files 185 185
Lines 25904 25904
=======================================
Hits 24368 24368
Misses 1536 1536 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the point of this? it's getting built for testing anyway. Or is it to specifically check the release build?
Yeah, the test build doesn't cover everything (it doesn't try building the actual binary/main entrypoint). We've had issues before where ampd build failed on main but the gh actions didn't fail on the PR |
Description
AXE-4509
Todos
Steps to Test
Expected Behaviour
Other Notes