Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ampd): build ampd in gh actions #533

Merged
merged 9 commits into from
Jul 24, 2024
Merged

ci(ampd): build ampd in gh actions #533

merged 9 commits into from
Jul 24, 2024

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Jul 23, 2024

Description

AXE-4509

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@milapsheth milapsheth requested review from a team as code owners July 23, 2024 20:25
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.07%. Comparing base (7e27cb7) to head (1be7b0e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files         185      185           
  Lines       25904    25904           
=======================================
  Hits        24368    24368           
  Misses       1536     1536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cgorenflo cgorenflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point of this? it's getting built for testing anyway. Or is it to specifically check the release build?

@milapsheth
Copy link
Member Author

what's the point of this? it's getting built for testing anyway. Or is it to specifically check the release build?

Yeah, the test build doesn't cover everything (it doesn't try building the actual binary/main entrypoint). We've had issues before where ampd build failed on main but the gh actions didn't fail on the PR

.github/workflows/basic.yaml Outdated Show resolved Hide resolved
@milapsheth milapsheth enabled auto-merge (squash) July 24, 2024 18:37
@milapsheth milapsheth merged commit 3359fc3 into main Jul 24, 2024
6 checks passed
@milapsheth milapsheth deleted the ci/ampd-build branch July 24, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants