Refuse to modify PVCs/PVs with a VAC associated #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torredil
previously approved these changes
Apr 19, 2024
|
Works on live cluster: |
AndrewSirenko
approved these changes
Apr 19, 2024
pkg/controller/controller.go
Outdated
| @@ -261,6 +261,14 @@ func (c *modifyController) modifyPVC(pv *v1.PersistentVolume, pvc *v1.Persistent | |||
| c.addPVCToInProgressList(pvc.Name) | |||
| defer c.removePVCFromInProgressList(pvc.Name) | |||
|
|
|||
| if pvc.Spec.VolumeAttributesClassName != nil && *pvc.Spec.VolumeAttributesClassName != "" { | |||
| c.eventRecorder.Eventf(pvc, v1.EventTypeWarning, VolumeModificationFailed, "Refusing to modify %s because PVC %s has a VAC associated", pv.Name, pvc.Name) | |||
There was a problem hiding this comment.
For increased clarity, consider adding 'via PVC annotation': "Refusing to modify %s because PVC %s has a VAC associated" -> "Refusing to modify %s via PVC annotation because PVC %s has a VAC associated"
Similar change for lines 265, 266, 268, 269.
I'm expecting some poor souls to forget there are two different ways to modify a volume.
Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
dont-modify-vac
branch
from
a802a74 to
d7fc875
Compare
torredil
approved these changes
Apr 22, 2024
|
/approve |
AndrewSirenko
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Refuses to modify volumes with a VAC associated, thus preventing multiple modifiers fighting over the same volume. We do not intend to support modifying volumes that are VAC-managed with
volume-modifier-for-k8s.(Also bumps all the dependencies which was needed to get the
VolumeAttributesClassNamefield available inclient-go)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.