-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Leader election conflict with csi-resizer bug fix
Signed-off-by: torredil <[email protected]>
- Loading branch information
Showing
5 changed files
with
248 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/awslabs/volume-modifier-for-k8s/pkg/controller" | ||
|
|
||
| v1 "k8s.io/api/coordination/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
| ) | ||
|
|
||
| func TestLeaseHandler_PodIsLeader(t *testing.T) { | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| mockModifyController := controller.NewMockModifyController(ctrl) | ||
|
|
||
| signalChannel := make(chan struct{}, 1) | ||
| mockModifyController.EXPECT().Run(gomock.Any(), gomock.Any()).Do( | ||
| func(_ int, _ context.Context) { | ||
| t.Log("Run was called") | ||
| signalChannel <- struct{}{} | ||
| }, | ||
| ).Times(1) | ||
|
|
||
| lease := newLease("external-resizer-ebs-csi-aws-com", "test-pod") | ||
| runLeaseHandlerAndSendLease(t, "test-pod", mockModifyController, lease) | ||
|
|
||
| select { | ||
| case <-signalChannel: | ||
| t.Log("Signal received, test passed") | ||
| case <-time.After(time.Second): | ||
| t.Fatal("Timeout waiting for Run to be called") | ||
| } | ||
| } | ||
|
|
||
| func TestLeaseHandler_PodIsNotLeader(t *testing.T) { | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| mockModifyController := controller.NewMockModifyController(ctrl) | ||
| mockModifyController.EXPECT().Run(gomock.Any(), gomock.Any()).Times(0) | ||
|
|
||
| lease := newLease("external-resizer-ebs-csi-aws-com", "other-pod") | ||
| runLeaseHandlerAndSendLease(t, "test-pod", mockModifyController, lease) | ||
| } | ||
|
|
||
| func TestLeaseHandler_PodRegainsLeadership(t *testing.T) { | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| mockModifyController := controller.NewMockModifyController(ctrl) | ||
|
|
||
| firstSignalChannel := make(chan struct{}, 1) | ||
| secondSignalChannel := make(chan struct{}, 1) | ||
|
|
||
| // Expect Run to be called once initially, signal via first channel | ||
| mockModifyController.EXPECT().Run(gomock.Any(), gomock.Any()).Do( | ||
| func(_ int, _ context.Context) { | ||
| t.Log("First Run was called") | ||
| firstSignalChannel <- struct{}{} | ||
| }, | ||
| ).Times(1) | ||
|
|
||
| // Expect Run to be called again after leadership loss, signal via second channel | ||
| mockModifyController.EXPECT().Run(gomock.Any(), gomock.Any()).Do( | ||
| func(_ int, _ context.Context) { | ||
| t.Log("Second Run was called") | ||
| secondSignalChannel <- struct{}{} | ||
| }, | ||
| ).Times(1) | ||
|
|
||
| leaseChannel := make(chan *v1.Lease, 3) | ||
| defer close(leaseChannel) | ||
|
|
||
| go leaseHandler("test-pod", mockModifyController, leaseChannel) | ||
|
|
||
| // Become the leader | ||
| leaseChannel <- newLease("external-resizer-ebs-csi-aws-com", "test-pod") | ||
| <-firstSignalChannel | ||
| // Lose the leadership | ||
| leaseChannel <- newLease("external-resizer-ebs-csi-aws-com", "other-pod") | ||
| // Regain the leadership | ||
| leaseChannel <- newLease("external-resizer-ebs-csi-aws-com", "test-pod") | ||
|
|
||
| select { | ||
| case <-secondSignalChannel: | ||
| t.Log("Test passed, second Run was called") | ||
| case <-time.After(time.Second): | ||
| t.Fatal("Timeout waiting for Run to be called") | ||
| } | ||
| } | ||
|
|
||
| func TestLeaseHandler_RunCalledOnce(t *testing.T) { | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| mockModifyController := controller.NewMockModifyController(ctrl) | ||
|
|
||
| signalChannel := make(chan struct{}, 1) | ||
|
|
||
| mockModifyController.EXPECT().Run(gomock.Any(), gomock.Any()).Do( | ||
| func(_ int, _ context.Context) { | ||
| t.Log("Run was called") | ||
| signalChannel <- struct{}{} | ||
| }, | ||
| ).Times(1) | ||
|
|
||
| leaseChannel := make(chan *v1.Lease, 3) | ||
| defer close(leaseChannel) | ||
|
|
||
| go leaseHandler("test-pod", mockModifyController, leaseChannel) | ||
|
|
||
| for i := 0; i < 10; i++ { | ||
| leaseChannel <- newLease("external-resizer-ebs-csi-aws-com", "test-pod") | ||
| } | ||
|
|
||
| select { | ||
| case <-signalChannel: | ||
| t.Log("Signal received, test passed") | ||
| case <-time.After(time.Second): | ||
| t.Fatal("Timeout waiting for Run to be called") | ||
| } | ||
| } | ||
|
|
||
| func newLease(name, holderIdentity string) *v1.Lease { | ||
| return &v1.Lease{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: name, | ||
| }, | ||
| Spec: v1.LeaseSpec{ | ||
| HolderIdentity: &holderIdentity, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func runLeaseHandlerAndSendLease(t *testing.T, podName string, mockModifyController *controller.MockModifyController, lease *v1.Lease) { | ||
| leaseChannel := make(chan *v1.Lease, 1) | ||
| go leaseHandler(podName, mockModifyController, leaseChannel) | ||
| leaseChannel <- lease | ||
| close(leaseChannel) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.