Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smithy to v2 #9

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update smithy to v2 #9

wants to merge 4 commits into from

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Feb 14, 2024

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@MikeDombo MikeDombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the generated code in any language?

@sfod
Copy link
Contributor Author

sfod commented Feb 15, 2024

The elements (types, functions, etc) are rearranged in the cpp, python, and JS generated files. But from the functional pov the generated code is the same. I'm currently trying to come up with a CI job that will verify that.

@sfod sfod marked this pull request as draft February 16, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants