-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dist][Pass] ZeRO optimization #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. One insight I got from this PR is that we really need an ANF pattern matcher...
Other than the comments I left, there are two points
Got it, Thanks! Will modify accordingly.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @zhen-jia |
Description
This PR performs all ZeRO related optimizations. There are two main optimizations and two passes are impacted. May changes are listed below:
5000000000
, which is in consistent with DeepSpeed. It can be set to 0 or 1 so as to not group any communications at all.Checklist
cc @awslabs/raf-reviewer