Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the name of a mounted bucket in block's metadata #1208

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

vladem
Copy link
Contributor

@vladem vladem commented Jan 3, 2025

The field x-amz-meta-source-bucket-name of the cache block was intended to store the name of the mounted bucket (source bucket). Currently it stores the name of the cache bucket.

Does this change impact existing behavior?

Yes, we update the version of the block schema. All blocks written with previous versions of Mountpoint won't be accessible (attempts will be cache misses).

Does this change need a changelog entry?

Yes.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:16 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:16 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:16 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:16 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:16 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:16 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:16 — with GitHub Actions Inactive
Signed-off-by: Vlad Volodkin <[email protected]>
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:34 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:34 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:34 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:34 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:34 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:34 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:34 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:50 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:50 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:50 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 13:50 — with GitHub Actions Inactive
@vladem vladem requested a review from passaro January 3, 2025 14:22
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only a minor suggestion.

mountpoint-s3/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alessandro Passaro <[email protected]>
Signed-off-by: Volodkin Vladislav <[email protected]>
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 15:30 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 15:30 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 15:30 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 15:30 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 15:30 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 15:30 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 3, 2025 15:30 — with GitHub Actions Inactive
@vladem vladem added this pull request to the merge queue Jan 3, 2025
Merged via the queue into awslabs:main with commit 4284e64 Jan 3, 2025
23 checks passed
@vladem vladem deleted the cache-xoz-source-bucket branch January 3, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants