-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify get_object by waiting for response headers #1171
Merged
Merged
+246
−316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 09:26
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 09:26
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 09:26
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 09:26
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 09:26
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 09:26
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 09:26
— with
GitHub Actions
Failure
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 10:55
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 10:55
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 10:55
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 10:55
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 10:56
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 10:56
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 10:56
— with
GitHub Actions
Inactive
passaro
added a commit
to passaro/mountpoint-s3
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 11:04
— with
GitHub Actions
Inactive
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 11:04
— with
GitHub Actions
Failure
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 11:04
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 11:04
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 11:04
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 11:04
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 11:04
— with
GitHub Actions
Inactive
passaro
had a problem deploying
to
PR integration tests
November 27, 2024 11:19
— with
GitHub Actions
Failure
passaro
temporarily deployed
to
PR integration tests
November 27, 2024 11:28
— with
GitHub Actions
Inactive
muddyfish
reviewed
Nov 27, 2024
passaro
added a commit
to passaro/mountpoint-s3
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
force-pushed
the
async-get-object
branch
from
November 29, 2024 08:40
e168e15
to
4a91348
Compare
passaro
temporarily deployed
to
PR integration tests
November 29, 2024 08:40
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
November 29, 2024 08:40
— with
GitHub Actions
Inactive
passaro
had a problem deploying
to
PR integration tests
December 5, 2024 09:25
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
December 5, 2024 09:25
— with
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
December 5, 2024 09:25
— with
GitHub Actions
Failure
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
force-pushed
the
async-get-object
branch
from
December 5, 2024 11:14
4d87c53
to
f5ab593
Compare
passaro
temporarily deployed
to
PR integration tests
December 5, 2024 11:14
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 5, 2024 11:14
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 5, 2024 11:14
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 5, 2024 11:14
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 5, 2024 11:14
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 5, 2024 11:14
— with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 5, 2024 11:14
— with
GitHub Actions
Inactive
vladem
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3CrtClient::get_object
was originally implemented so that it would complete immediately and return aGetObjectRequest
implementation (extendingStream
) to retrieve body parts. Any error from the S3 request would be returned through the stream.We recently added additional methods (
get_object_metadata
in #1065 andget_object_checksum
in #1123) to the response that rely on the headers returned by the (first)GetObject
request. The new methods required an async signature and a complicated implementation in order to account for failures and they still do not correctly report accurate error information in some cases.With this change, we modify
get_object
to await for response headers before returning either an error or aGetObjectResponse
(note the name change) implementation. The ergonomics ofget_object
are improved:await
ing the initial call can already return some errors (e.g. bucket/key not found),get_object_checksum
andget_object_metadata
are now sync functions.Does this change impact existing behavior?
Yes,
get_object
behavior is different,get_object_checksum
andget_object_metadata
signatures have changed, andGetObjectRequest
was renamed toGetObjectResponse
.Does this change need a changelog entry?
Yes, it requires a breaking change entry for
mountpoint-s3-client
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).