Skip to content

Commit

Permalink
Remove old TODO (#1167)
Browse files Browse the repository at this point in the history
The issue has already been addressed in Cancel S3 requests when dropped
[#794](#794).

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

Signed-off-by: Alessandro Passaro <[email protected]>
  • Loading branch information
passaro authored Nov 25, 2024
1 parent c66546a commit e7ce3a0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion mountpoint-s3/src/fs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,6 @@ where

let write_state = match file_handle.state.into_inner() {
FileHandleState::Read { handle, .. } => {
// TODO make sure we cancel the inflight PrefetchingGetRequest. is just dropping enough?
metrics::gauge!("fs.current_handles", "type" => "read").decrement(1.0);
handle.finish()?;
return Ok(());
Expand Down

0 comments on commit e7ce3a0

Please sign in to comment.