-
Notifications
You must be signed in to change notification settings - Fork 166
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor
ObjectClient.get_object
to use an GetObjectParams
parame…
…ter (#1121) <!-- The title and description of pull requests will be used when creating a squash commit to the base branch (usually `main`). Please keep them both up-to-date as the code change evolves, to ensure that the commit message is useful for future readers. --> ## Description of change Refactor `ObjectClient.get_object` to use an `&GetObjectParams` parameter. Migrates the two existing parameters, `range` and `if_match` to `GetObjectParams` and changes all call sites. <!-- Please describe your contribution here. What is the change and why are you making it? --> Relevant issues: N/A ## Does this change impact existing behavior? No <!-- Please confirm there's no breaking change, or call our any behavior changes you think are necessary. --> ## Does this change need a changelog entry in any of the crates? Yes. Breaking change in mountpoint-s3-client. <!-- Please confirm yes or no. If no, add justification. If unsure, ask a reviewer. You can find the changelog for each crate here: - https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3/CHANGELOG.md - https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3-client/CHANGELOG.md - https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3-crt/CHANGELOG.md - https://github.com/awslabs/mountpoint-s3/blob/main/mountpoint-s3-crt-sys/CHANGELOG.md --> --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Simon Beal <[email protected]>
- Loading branch information
Showing
19 changed files
with
181 additions
and
114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.