Skip to content

Commit

Permalink
Add more initial support for merge_queues
Browse files Browse the repository at this point in the history
Fixup based on comments on previous PR
  • Loading branch information
muddyfish committed Jan 14, 2025
1 parent 5c67b96 commit d873362
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,33 +41,28 @@ jobs:
- name: Login to Amazon ECR (trusted)
id: login-ecr-trusted
uses: aws-actions/amazon-ecr-login@v1
with:
mask-password: true

- name: Configure AWS Credentials from Prod account
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ vars.PROD_IAM_IMAGE_ROLE }}
aws-region: ${{ vars.AWS_PROD_ECR_REGION }}
- name: Login to Amazon ECR prod
- name: Login to Amazon ECR (prod)
id: login-ecr-prod
uses: aws-actions/amazon-ecr-login@v1
with:
mask-password: true

- name: Configure AWS Credentials from Prod account (for ECR public)
if: ${{ env.PUBLIC_REGISTRY != '' }}
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ vars.PROD_IAM_IMAGE_ROLE }}
aws-region: us-east-1
- name: Login to Amazon ECR Public
- name: Login to Amazon ECR (public)
if: ${{ env.PUBLIC_REGISTRY != '' }}
id: login-ecr-public
uses: aws-actions/amazon-ecr-login@v1
with:
registry-type: public
mask-password: true

- name: Promote image
env:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/unit-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
branches: [ "main", "feature/*" ]
pull_request:
branches: [ "main", "feature/*" ]
merge_group:
types: [ "checks_requested" ]

jobs:
build:
Expand Down

0 comments on commit d873362

Please sign in to comment.