Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVRE reporting for short lived instances #427

Merged
merged 15 commits into from
Nov 8, 2023
Merged

PVRE reporting for short lived instances #427

merged 15 commits into from
Nov 8, 2023

Conversation

smahendarkar
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hakuna-matatah
Copy link
Contributor

hakuna-matatah commented Oct 13, 2023 •
edited
Loading

Have we verified that this template fixes two issues that we have been having ?

@smahendarkar
Copy link
Contributor Author

smahendarkar commented Oct 13, 2023 •
edited
Loading

I created a launch template running this CFN stack in my dev account. If I can have permissions for perf lab, I can validate if we can create a MNG with this LT which ideally should fix the issues. Not sure if I could validate it further

@hakuna-matatah
Copy link
Contributor

I created a launch template running this CFN stack in my dev account. If I can have permissions for perf lab, I can validate if we can create a MNG with this LT which ideally should fix the issues. Not sure if I could validate it further

I will give you access to perflab, we should verify if this task is running smoothly on experimental infra.

@hakuna-matatah
Copy link
Contributor

Overall nice work @sushimaAws.

hakuna-matatah
hakuna-matatah previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@hakuna-matatah hakuna-matatah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@hakuna-matatah
Copy link
Contributor

Do not merge until internal changes are reviewed and merged as it will break current tests.

ashishranjan738
ashishranjan738 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ashishranjan738 ashishranjan738 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ashishranjan738 ashishranjan738 merged commit 5f48bf6 into awslabs:main Nov 8, 2023
hakuna-matatah added a commit to hakuna-matatah/kubernetes-iteration-toolkit that referenced this pull request Dec 2, 2023
@hakuna-matatah
Revert "PVRE reporting for short lived instances (awslabs#427)"
51a6c87 
This reverts commit 5f48bf6.
@hakuna-matatah hakuna-matatah mentioned this pull request Dec 2, 2023
Merged
hakuna-matatah added a commit that referenced this pull request Dec 2, 2023
@hakuna-matatah
Revert "PVRE reporting for short lived instances (#427)"
25e9f3b 
This reverts commit 5f48bf6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishranjan738 ashishranjan738 ashishranjan738 approved these changes

@hakuna-matatah hakuna-matatah hakuna-matatah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smahendarkar @hakuna-matatah @ashishranjan738