Add variable for disk size and increase default #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananth102
changed the title
|
Have we verified that this change, resolved the issue you encountered with disk-space? |
Yea |
surajkota
approved these changes
Aug 23, 2023
surajkota
requested changes
Aug 23, 2023
deployments/rds-s3/terraform/main.tf
Outdated
| @@ -40,6 +40,7 @@ locals { | |||
| desired_size = 3 | |||
| max_size = 5 | |||
| ami_type = "AL2_x86_64_GPU" | |||
| disk_size = 75 | |||
There was a problem hiding this comment.
can we make this a configurable var instead?
ryansteakley
approved these changes
Aug 23, 2023
surajkota
approved these changes
Aug 24, 2023
ananth102
changed the title
rakuto
pushed a commit
to tne-ai/kubeflow-manifests
that referenced
this pull request
Sep 27, 2023
**Which issue is resolved by this Pull Request:** DLC gpu images take up too much disk space, which leads to disk pressure errors. Second revision: Adding a variable to configure disk size. **Description of your changes:** This PR increases the disk size from 50gb (default) to 75gb for gpu nodes. **Testing:** - [ ] Unit tests pass - [x] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed - Manually tested with public.ecr.aws/kubeflow-on-aws/notebook-servers/jupyter-pytorch:2.0.0-gpu-py310-cu118-ubuntu20.04-ec2-v1.0, no disk pressure errors. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
DLC gpu images take up too much disk space, which leads to disk pressure errors.
Second revision:
Adding a variable to configure disk size.
Description of your changes:
This PR increases the disk size from 50gb (default) to 75gb for gpu nodes.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.