Migrate to v5 blueprints #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| eks_cluster_id = module.eks_blueprints.eks_cluster_id |
There was a problem hiding this comment.
is this field removed in latest versions?
There was a problem hiding this comment.
ryansteakley
approved these changes
Aug 21, 2023
surajkota
requested changes
Aug 23, 2023
surajkota
reviewed
Aug 24, 2023
surajkota
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
This PR lgtm, although there is a miss in previous RDS version update PR, see - #785 (comment)
I will leave it to you if you want to open separate PR if thats easier
rakuto
pushed a commit
to tne-ai/kubeflow-manifests
that referenced
this pull request
Sep 27, 2023
**Which issue is resolved by this Pull Request:** Resolves awslabs#775 **Description of your changes:** Upgrade to v5 blueprints for the eks addons Major changes: 1. v5 does not have an option to enable the ebs csi driver, will need to do with the help of another module 2. v5 does not have an option for enabling the nvidia plugin, an operator is used instead. 3. V5/V4 parameters are different. **Testing:** - [ ] Unit tests pass - [x] e2e tests pass - Cognito, rds-s3-static, rds/s3-irsa passes, efs/fsx look fine manually. Need to test nvidia. - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed - GPU testing By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #775
Description of your changes:
Upgrade to v5 blueprints for the eks addons
Major changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.