Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding aws load balancer controller module #778

Closed
wants to merge 1 commit into from

Conversation

ananth102
Copy link
Contributor

@ananth102 ananth102 commented Aug 14, 2023

Which issue is resolved by this Pull Request:
Resolves #775

Description of your changes:
Creating a custom module for the AWS Load Balancer controller. Ideally this would be present in the module by aws-ia but policy size limitations prevent it for v5 and changes aren't being accepted for v4.

I tried using v5 but ran into issues with policy sizes. This solution uses the eks blueprint addon. The same method as the actual v5 load balancer addon but with a shortened policy size.

The policy specified here has 6001 characters. The new permissions require 402 characters which makes the policy more than 6144 characters ie the character size limit. Even specifying a custom policy does not seem to work.

Testing:

  • Unit tests pass
  • e2e tests pass - Congnito and vanilla pass
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ananth102 ananth102 changed the title adding aws load balancer module Adding aws load balancer controller module Aug 14, 2023
@surajkota
Copy link
Contributor

surajkota commented Aug 14, 2023

I dont understand how using a policy from file vs created using terraform is different? for the char limit mentioned in the PR description

and why cant this be fixed upstream in eks-blueprints-addon repo? how is this issue is specific to our usecase
It seems to me that blueprints folks need to rewrite their policy if its only happening due to the way they have structured the policy

@surajkota
Copy link
Contributor

surajkota commented Aug 14, 2023

FYI @askulkarni2. This campaign affects everyone using eks blueprints, can you work with Ananth to find a way forward?

@ananth102
Copy link
Contributor Author

I dont understand how using a policy from file vs created using terraform is different? for the char limit mentioned in the PR description

and why cant this be fixed upstream in eks-blueprints-addon repo? how is this issue is specific to our usecase

One of the differences I could find was the policy in this repo using * for account id and region and the policy in blueprints using the actual account id and region. The ideal fix would be to allow for more or custom policies.

# IAM role for service account (IRSA)
create_role = true
set_irsa_names = ["serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn"]
role_name = try(var.role_name, "alb-controller")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add cluster name and region to this to avoid collisions?

@surajkota
Copy link
Contributor

surajkota commented Aug 15, 2023

FYI aws-ia/terraform-aws-eks-blueprints-addons#229 blueprints released a new version. lets use it

@ananth102 ananth102 closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing permissions for alb-load-balancer-controller sa
2 participants