Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EFS Driver Version to v1.5.4 #664

Merged
merged 18 commits into from
Apr 7, 2023
Merged

Update EFS Driver Version to v1.5.4 #664

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
632ec70
[Cherry Pick] Enable canary report generation (#634)
jsitu777 Mar 30, 2023
bbfbb3e
Merge remote-tracking branch 'upstream/main'
jsitu777 Mar 30, 2023
1a34003
Revert "[Cherry Pick] Enable canary report generation (#634)"
jsitu777 Mar 30, 2023
586ca6a
Merge remote-tracking branch 'upstream/main'
jsitu777 Mar 31, 2023
6448279
Merge remote-tracking branch 'upstream/main'
jsitu777 Mar 31, 2023
b918541
Merge remote-tracking branch 'upstream/main'
jsitu777 Mar 31, 2023
1554654
Merge remote-tracking branch 'upstream/main'
jsitu777 Mar 31, 2023
2224ee9
Merge remote-tracking branch 'upstream/main'
jsitu777 Apr 5, 2023
344cfa0
Merge remote-tracking branch 'upstream/main'
jsitu777 Apr 6, 2023
8a5566c
update efs driver version
jsitu777 Apr 6, 2023
4750e5e
minor fix
jsitu777 Apr 6, 2023
4babf7b
update v1.5.4 kustomize link
jsitu777 Apr 6, 2023
bc98bed
add efs helm version in terraform for all deployment options
jsitu777 Apr 7, 2023
2c52afa
change efs csidriver name in helm config for terraform
jsitu777 Apr 7, 2023
516ff1c
Merge remote-tracking branch 'upstream/main' into efs-update
jsitu777 Apr 7, 2023
19f1eda
add back underscore
jsitu777 Apr 7, 2023
30d2e86
change kustomize apply -k url to version tag
jsitu777 Apr 7, 2023
f917b42
add missing tag
jsitu777 Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/e2e/fixtures/storage_efs_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def callback():
@pytest.fixture(scope="class")
def install_efs_csi_driver(metadata, region, request, cluster, installation):
efs_driver = {}
EFS_DRIVER_VERSION = "v1.3.4"
EFS_DRIVER_VERSION = "v1.5.4"
EFS_CSI_DRIVER = f"github.com/kubernetes-sigs/aws-efs-csi-driver/deploy/kubernetes/overlays/stable/?ref=tags/{EFS_DRIVER_VERSION}"

def on_create():
Expand All @@ -122,7 +122,7 @@ def create_efs_driver_sa(
efs_deps = {}
iam_client = boto3.client("iam")

EFS_IAM_POLICY = "https://raw.githubusercontent.com/kubernetes-sigs/aws-efs-csi-driver/v1.3.4/docs/iam-policy-example.json"
EFS_IAM_POLICY = "https://raw.githubusercontent.com/kubernetes-sigs/aws-efs-csi-driver/v1.5.4/docs/iam-policy-example.json"
policy_name = rand_name("efs-iam-policy-")
policy_arn = [f"arn:aws:iam::{account_id}:policy/{policy_name}"]

Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/utils/auto-efs-setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def create_efs_iam_policy():


def get_efs_iam_policy_document():
url = "https://raw.githubusercontent.com/kubernetes-sigs/aws-efs-csi-driver/v1.4.0/docs/iam-policy-example.json"
url = "https://raw.githubusercontent.com/kubernetes-sigs/aws-efs-csi-driver/v1.5.4/docs/iam-policy-example.json"
response = urllib.request.urlopen(url)
data = response.read()
return data.decode("utf-8")
Expand Down Expand Up @@ -184,7 +184,7 @@ def install_efs_driver():
print("Installing EFS driver...")

kubectl_kustomize_apply(
"https://github.com/kubernetes-sigs/aws-efs-csi-driver/deploy/kubernetes/overlays/stable/?ref=tags/v1.4.0"
"https://github.com/kubernetes-sigs/aws-efs-csi-driver/deploy/kubernetes/overlays/stable/?ref=release-1.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per the documentation this is the right way, and I tested it. https://github.com/kubernetes-sigs/aws-efs-csi-driver/tree/v1.5.4#deploy-the-driver

kubectl apply -k "github.com/kubernetes-sigs/aws-efs-csi-driver/deploy/kubernetes/overlays/stable/?ref=release-1.5"  

serviceaccount/efs-csi-controller-sa created
serviceaccount/efs-csi-node-sa created
clusterrole.rbac.authorization.k8s.io/efs-csi-external-provisioner-role created
clusterrolebinding.rbac.authorization.k8s.io/efs-csi-provisioner-binding created
deployment.apps/efs-csi-controller created
daemonset.apps/efs-csi-node created
csidriver.storage.k8s.io/efs.csi.aws.com configured

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag also works. changed.

)

print("EFS driver installed!")
Expand Down
6 changes: 3 additions & 3 deletions website/content/en/docs/add-ons/storage/efs/guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ export AWS_ACCOUNT_ID=$(aws sts get-caller-identity --query "Account" --output t
```

#### 1. Install the EFS CSI driver
We recommend installing the EFS CSI Driver v1.3.4 directly from the [the aws-efs-csi-driver github repo](https://github.com/kubernetes-sigs/aws-efs-csi-driver) as follows:
We recommend installing the EFS CSI Driver v1.5.4 directly from the [the aws-efs-csi-driver github repo](https://github.com/kubernetes-sigs/aws-efs-csi-driver) as follows:

```bash
kubectl apply -k "github.com/kubernetes-sigs/aws-efs-csi-driver/deploy/kubernetes/overlays/stable/?ref=tags/v1.3.4"
kubectl apply -k "github.com/kubernetes-sigs/aws-efs-csi-driver/deploy/kubernetes/overlays/stable/?ref=tags/release-1.5"
```

You can confirm that EFS CSI Driver was installed into the default kube-system namespace for you. You can check using the following command:
Expand All @@ -101,7 +101,7 @@ The CSI driver's service account (created during installation) requires IAM perm
1. Download the IAM policy document from GitHub as follows.

```bash
curl -o iam-policy-example.json https://raw.githubusercontent.com/kubernetes-sigs/aws-efs-csi-driver/v1.3.4/docs/iam-policy-example.json
curl -o iam-policy-example.json https://raw.githubusercontent.com/kubernetes-sigs/aws-efs-csi-driver/v1.5.4/docs/iam-policy-example.json
```

2. Create the policy.
Expand Down