Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/s3nopublic #518

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Task/s3nopublic #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b46390
add default public access block for s3 bucket
rddefauw Dec 3, 2022
1efaf14
change resource name to be more specific
rddefauw Dec 6, 2022
0155496
add note on default s3 bucket public access block
rddefauw Dec 6, 2022
b71e690
Merge branch 'main' into task/s3nopublic
rddefauw Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions iaac/terraform/aws-infra/s3/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,13 @@ resource "aws_secretsmanager_secret_version" "s3_secret_version" {
accesskey = var.minio_aws_access_key_id
secretkey = var.minio_aws_secret_access_key
})
}

resource "aws_s3_bucket_public_access_block" "artifact_store_block_access" {
bucket = aws_s3_bucket.artifact_store.id

block_public_acls = true
block_public_policy = true
ignore_public_acls = true
restrict_public_buckets = true
}
9 changes: 9 additions & 0 deletions tests/e2e/utils/rds-s3/auto-rds-s3-setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,15 @@ def create_s3_bucket(s3_client):
args["CreateBucketConfiguration"] = {"LocationConstraint": CLUSTER_REGION}

s3_client.create_bucket(**args)
s3_client.put_public_access_block(
Bucket=S3_BUCKET_NAME,
PublicAccessBlockConfiguration={
'BlockPublicAcls': True,
'IgnorePublicAcls': True,
'BlockPublicPolicy': True,
'RestrictPublicBuckets': True
}
)
print("S3 bucket created!")

s3_client.put_bucket_encryption(
Expand Down
6 changes: 6 additions & 0 deletions website/content/en/docs/about/security.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ We highly recommend that you follow AWS security best practices while provisioni

### Amazon Simple Storage Service (S3)

#### Block public access

The Amazon S3 bucket created for Kubeflow artifacts has a default ["block public access" configuration](https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-control-block-public-access.html).

#### Encryption

When you use Amazon S3 for kubeflow artifact storage, Kubeflow on AWS configures the Amazon S3 bucket to use [server-side encryption with Amazon S3-managed encryption keys](https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingServerSideEncryption.html) (SSE-S3). If you prefer to use [server-side encryption with AWS Key Management Service](https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingKMSEncryption.html) (SSE-KMS), you can modify these files to specify an AWS KMS key.

* [main.tf](https://github.com/awslabs/kubeflow-manifests/blob/main/iaac/terraform/aws-infra/s3/main.tf) for Terraform deployments
Expand Down