Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSE-s3 encryption on S3 buckets by default #517

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Enable SSE-s3 encryption on S3 buckets by default #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae51867
Add S3 SSE-S3 encryption by default for terraform and manifest deploy…
rddefauw Dec 1, 2022
b45ad61
Use better resource name for s3 encryption in terraform
rddefauw Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions iaac/terraform/aws-infra/s3/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ resource "aws_s3_bucket" "artifact_store" {
force_destroy = var.force_destroy_bucket
}

resource "aws_s3_bucket_server_side_encryption_configuration" "artifact_store_encryption" {
bucket = aws_s3_bucket.artifact_store.bucket

rule {
apply_server_side_encryption_by_default {
sse_algorithm = "AES256"
}
}
}

resource "aws_secretsmanager_secret" "s3_secret" {
name_prefix = "s3-secret-"
recovery_window_in_days = var.secret_recovery_window_in_days
Expand Down
13 changes: 13 additions & 0 deletions tests/e2e/utils/rds-s3/auto-rds-s3-setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,19 @@ def create_s3_bucket(s3_client):
s3_client.create_bucket(**args)
print("S3 bucket created!")

s3_client.put_bucket_encryption(
Bucket=S3_BUCKET_NAME,
ServerSideEncryptionConfiguration={
'Rules': [
{
'ApplyServerSideEncryptionByDefault': {
'SSEAlgorithm': 'AES256'
}
},
]
}
)


def setup_s3_secrets(secrets_manager_client):
if not does_secret_already_exist(secrets_manager_client, S3_SECRET_NAME):
Expand Down
11 changes: 11 additions & 0 deletions website/content/en/docs/about/security.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ weight = 40

We highly recommend that you follow AWS security best practices while provisioning any AWS resources.

## Default security configuration

### Amazon Simple Storage Service (S3)

When you use Amazon S3 for kubeflow artifact storage, Kubeflow on AWS configures the Amazon S3 bucket to use [server-side encryption with Amazon S3-managed encryption keys](https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingServerSideEncryption.html) (SSE-S3). If you prefer to use [server-side encryption with AWS Key Management Service](https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingKMSEncryption.html) (SSE-KMS), you can modify these files to specify an AWS KMS key.

* [main.tf](https://github.com/awslabs/kubeflow-manifests/blob/main/iaac/terraform/aws-infra/s3/main.tf) for Terraform deployments
* [auto-rds-s3-setup.py](https://github.com/awslabs/kubeflow-manifests/blob/main/tests/e2e/utils/rds-s3/auto-rds-s3-setup.py) for manifest deployments

Both SSE-S3 and SSE-KMS provide encryption of objects in the Amazon S3 bucket. You may prefer SSE-KMS if you want to separate the management of encryption keys (via AWS KMS) from management of the Amazon S3 bucket. That separation may provide a stronger security posture. In order to access and use an object in an Amazon S3 bucket, a user needs permission to read the object in the Amazon S3 bucket as well as permission to use the AWS KMS encryption key.

## Security resources

Refer to the following documents for more information:
Expand Down