Enable KFP Visualizations and Artifact Store with S3 as source for s3 deployments #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaijal
commented
Oct 7, 2022
| Settings are pulled from the all-caps version of the setting name. The | ||
| following defaults are used if those environment variables are not set | ||
| to enable backwards compatibility with previous versions of this script: | ||
| visualization_server_image: gcr.io/ml-pipeline/visualization-server |
There was a problem hiding this comment.
Add the minio_service_region and default here
surajkota
approved these changes
Oct 7, 2022
akartsky
reviewed
Oct 7, 2022
akartsky
approved these changes
Oct 7, 2022
2 tasks
jsitu777
added a commit
that referenced
this pull request
Oct 11, 2022
…harts (#463) **Which issue is resolved by this Pull Request:** Resolves # **Description of your changes:** -modify pipeline charts based on #456 **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #117
Description of your changes:
Enable KFP Visualizations and Artifact Store with S3 as source for s3 deployments
TBD: Tensorboard
Testing:
Tested using kustomize rds-s3 deployment only.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.