Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Rename Transform struct to TemplateTransform #332

Closed
wants to merge 2 commits into from
Closed

Rename Transform struct to TemplateTransform #332

wants to merge 2 commits into from

Conversation

xrn
Copy link
Contributor

@xrn xrn commented Nov 6, 2020

Issue #, if available:

Description of changes:
I need to use in my stack implementation Fn::Transform (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-transform.html) but this intrinsic function is not implemented. I would like to implement it as cloudformation.Transform() but this name is already blocked by Template.Transform struct name. I would like to rename it and then in the next PR implement cloudformation.Transform

This PR is also solving #294

If you have any ideas on how this can be implemented better - by for example creating a template package or sth like that I am happy to work on this.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@xrn xrn changed the title Rename Transform struct to Template_Transform Rename Transform struct to TemplateTransform Nov 6, 2020
@xrn
Copy link
Contributor Author

xrn commented Nov 10, 2020

@PaulMaddox - what do you think?

@PaulMaddox
Copy link
Contributor

I'd rather not make such a breaking change to the public API.

It's probably easier to name the intrinsic method something like cloudformation.TransformFn(). I know that's a bit ugly as it differs from the others.

@PaulMaddox
Copy link
Contributor

I believe this can be closed now that #352 is merged.

@PaulMaddox PaulMaddox closed this Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants