Skip to content
This repository was archived by the owner on Apr 13, 2023. It is now read-only.

feat!: add methods to persistence and search interface for subscription #94

Merged
merged 8 commits into from
Jan 18, 2022

Conversation

Bingjiling
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Add isSubscriptionSearchCriteriaValid(searchCriteria: string): Boolean; to search
  • Add getActiveSubscriptions(params: { tenantId?: string }): Promise<Record<string, any>[]>; to persistence

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Bingjiling Bingjiling requested a review from a team as a code owner January 7, 2022 19:18
@github-actions github-actions bot added the size/s label Jan 7, 2022
@Bingjiling Bingjiling requested a review from carvantes January 10, 2022 18:38
@Bingjiling Bingjiling merged commit 74a2b33 into feat-subscriptions Jan 18, 2022
@Bingjiling Bingjiling deleted the subscription-change branch January 18, 2022 17:17
carvantes added a commit that referenced this pull request Mar 3, 2022
* feat: add getActiveSubscriptions interface (#95)
* feat!: search and validate update for subscription data validation(#94)
* feat: Validator change (#97)

Co-authored-by: Sukeerth Vegaraju <[email protected]>
Co-authored-by: Yanyu Zheng <[email protected]>

BREAKING CHANGE: add new required methods `getActiveSubscriptions` and `validateSubscriptionSearchCriteria`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants