Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using AL2023 GPU based AMI(s) #264

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Support for using AL2023 GPU based AMI(s) #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/resource/nodegroup/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ const eksOptmizedGpuAmiPath = "/aws/service/eks/optimized-ami/%s/amazon-linux-2-
// /aws/service/eks/optimized-ami/<eks-version>/amazon-linux-2023/x86_64/standard/recommended/image_id
const eksOptimized2023AmiPath = "/aws/service/eks/optimized-ami/%s/amazon-linux-2023/x86_64/standard/recommended/image_id"

// /aws/service/eks/optimized-ami/<eks-version>/amazon-linux-2023/x86_64/nvidia/recommended/image_id
const eksOptimized2023GpuAmiPath = "/aws/service/eks/optimized-ami/%s/amazon-linux-2023/x86_64/nvidia/recommended/image_id"

// /aws/service/eks/optimized-ami/<eks-version>/amazon-linux-2023/arm64/standard/recommended/image_id
const eksOptimized2023ArmAmiPath = "/aws/service/eks/optimized-ami/%s/amazon-linux-2023/arm64/standard/recommended/image_id"

Expand Down Expand Up @@ -235,10 +238,11 @@ func (o *NodegroupOptions) PreCreate() error {
return fmt.Errorf("%q instance type is not supported with the EKS optimized Amazon Linux AMI", "G5g")

case isNeuron, isNvidia:
path := eksOptmizedGpuAmiPath
if o.OperatingSystem == "AmazonLinux2023" {
return fmt.Errorf("EKS optimized Amazon Linux 2023 AMI does not support GPU(s) or Neuron devices yet")
path = eksOptimized2023GpuAmiPath
}
param, err := ssmClient.GetParameter(fmt.Sprintf(eksOptmizedGpuAmiPath, o.KubernetesVersion))
param, err := ssmClient.GetParameter(fmt.Sprintf(path, o.KubernetesVersion))
if err != nil {
return fmt.Errorf("failed to lookup EKS optimized accelerated AMI for instance type %s: %w", o.InstanceType, err)
}
Expand Down