Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding managed scaling to EMR workshop #194

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Adding managed scaling to EMR workshop #194

merged 4 commits into from
Aug 1, 2022

Conversation

sacksi28
Copy link
Contributor

Description of changes:

  • Adds managed scaling to EMR workshop.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jagpk
jagpk reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@jagpk jagpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution, please address the review comments.

content/running_spark_apps_with_emr_on_spot_instances/selecting_instance_types.md Outdated Show resolved Hide resolved
content/running_spark_apps_with_emr_on_spot_instances/scaling_emr_cluster.md Outdated Show resolved Hide resolved
content/running_spark_apps_with_emr_on_spot_instances/scaling_emr_cluster.md Outdated Show resolved Hide resolved
content/running_spark_apps_with_emr_on_spot_instances/scaling_emr_cluster.md Outdated Show resolved Hide resolved
@sacksi28 sacksi28 force-pushed the add-emr-managed-scaling branch 2 times, most recently from 3010b09 to 959b154 Compare June 20, 2022 16:39
@sacksi28
Copy link
Contributor Author

sacksi28 commented Jun 20, 2022 •
edited
Loading

@jagpk made necessary changes! This is ready for another review.

@sacksi28 sacksi28 force-pushed the add-emr-managed-scaling branch from c08d845 to 311ad03 Compare July 13, 2022 15:40
@sacksi28 sacksi28 force-pushed the add-emr-managed-scaling branch from 311ad03 to b271450 Compare July 19, 2022 09:39
@sacksi28 sacksi28 force-pushed the add-emr-managed-scaling branch from a2acc41 to 017c42e Compare August 1, 2022 12:51
@sacksi28 sacksi28 force-pushed the add-emr-managed-scaling branch from 017c42e to 778abc8 Compare August 1, 2022 14:18
jagpk
jagpk approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@jagpk jagpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions, I have completed the review.
GTM

@jagpk jagpk merged commit ff4aa6e into awslabs:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagpk jagpk jagpk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sacksi28 @jagpk