Fix issue 185 - request cannot rewind during retry #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinlin123
changed the title
|
Ack the CD failure. I will take a look soon. |
alvinlin123
commented
Jan 26, 2024
| @@ -222,15 +240,15 @@ func (p *ProxyClient) Do(req *http.Request) (*http.Response, error) { | |||
| } | |||
|
|
|||
| if (p.LogFailedRequest || log.GetLevel() == log.DebugLevel) && resp.StatusCode >= 400 { | |||
| b, _ := ioutil.ReadAll(resp.Body) | |||
| b, _ := io.ReadAll(resp.Body) | |||
There was a problem hiding this comment.
This is changed because ioutil pkg is deprecated after go 1.6
roystchiang
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#185
Description of changes:
Need to store the upstream request body into memory so we can retry in case of retriable networking error to down stream.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.