Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling for optional regions #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exception handling for optional regions #56

wants to merge 1 commit into from

Conversation

pacohope
Copy link

@pacohope pacohope commented Sep 4, 2020

I added a few extra exception handlers that wrap around calls to the Config service. If the region is an optional region, and the account hasn't opted into it, then this catches the exception and writes a failure note explaining why. There was also a missing continue near the if not config_result which explains why failed accounts caused problems and weren't handled gracefully the way they were meant to.

Strictly speaking, the unhandled exceptions are being thrown on line 121, but I catch them farther down because it lets me create a nice error message.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant