Exception handling for optional regions #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few extra exception handlers that wrap around calls to the Config service. If the region is an optional region, and the account hasn't opted into it, then this catches the exception and writes a failure note explaining why. There was also a missing
continue
near theif not config_result
which explains why failed accounts caused problems and weren't handled gracefully the way they were meant to.Strictly speaking, the unhandled exceptions are being thrown on line 121, but I catch them farther down because it lets me create a nice error message.