Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export ByteStream's Length and FsBuilder #820

Closed
jdisanti opened this issue Jun 6, 2023 · 2 comments
Closed

Re-export ByteStream's Length and FsBuilder #820

jdisanti opened this issue Jun 6, 2023 · 2 comments
Assignees
@ysaito1001
Labels
bug This issue is a bug. p3 This is a minor priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@jdisanti
Copy link
Contributor

jdisanti commented Jun 6, 2023 •
edited
Loading

ByteStream is re-exported in the primitives module, but not all of the read_from features can be used without directly depending on Smithy runtime crates because Length and FsBuilder are not re-exported.
@jdisanti jdisanti added the bug This issue is a bug. label Jun 6, 2023
@rcoh rcoh added the p3 This is a minor priority issue label Aug 8, 2023
@ysaito1001 ysaito1001 self-assigned this Aug 19, 2024
@ysaito1001 ysaito1001 mentioned this issue Aug 19, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this issue Aug 20, 2024
@ysaito1001
Re-export ByteStream's Length and FsBuilder in client crates (#…
8ccd2da 
…3796)

## Motivation and Context
awslabs/aws-sdk-rust#820

## Description
This PR re-exports `ByteStream`'s `Length` and `FsBuilder`. By making
these types available in a client crate, customers can use
`ByteStream::read_from` without needing to import them separately from
the `aws-smithy-types` crate.

## Testing
- Updated an existing re-export test to include `Length` and `FsBuilder`
as well.
- Existing tests in CI

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] For changes to the smithy-rs codegen or runtime crates, I have
created a changelog entry Markdown file in the `.changelog` directory,
specifying "client," "server," or both in the `applies_to` key.
- [x] For changes to the AWS SDK, generated SDK code, or SDK runtime
crates, I have created a changelog entry Markdown file in the
`.changelog` directory, specifying "aws-sdk-rust" in the `applies_to`
key.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@ysaito1001 ysaito1001 added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Aug 20, 2024
@landonxjames
Copy link
Contributor

This was released several weeks ago, closing.

@github-actions GitHub Actions
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysaito1001 ysaito1001

Labels
bug This issue is a bug. p3 This is a minor priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdisanti @rcoh @landonxjames @ysaito1001