fix: resolve region only when profile credentials require it #582
Conversation
|
A new generated diff is ready to view: __generated-main...__generated-fix-unnecessary-region-resolution |
|
A new generated diff is ready to view: __generated-main...__generated-fix-unnecessary-region-resolution |
| @@ -115,40 +116,49 @@ public class ProfileCredentialsProvider( | |||
| return creds | |||
| } | |||
|
|
|||
| private suspend fun resolveRegionOrThrow(platformProvider: PlatformProvider): String = | |||
| runCatching { resolveRegion(platformProvider) } | |||
There was a problem hiding this comment.
fix
resolveRegion already throws an exception that includes the entire chain that was tried. I think we should keep that behavior rather than throwing a new exception that lacks these details.
|
A new generated diff is ready to view: __generated-main...__generated-fix-unnecessary-region-resolution |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-fix-unnecessary-region-resolution |
Issue #
#581
Description of changes
This change removes the eager resolution of region in the profile credentials provider, which is unnecessary and can cause exceptions even when the region isn't needed (e.g., for static profile credentials).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.