-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only set Content-Type when appropriate #570
Conversation
A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2 |
protocol: "aws.protocols#restXml", | ||
method: "PUT", | ||
uri: "/mybucket", | ||
host: "s3.us-west-2.amazonaws.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to be explicit or at least put a comment in here since we can't actually create this exact request in the real world (anything other than us-east-1
IIRC requires the location constraint which results in a body)
A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2 |
A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2 |
Protocol tests for Content-Type. Also verifies Content-Length for both cases (body vs. empty).
Issue #
#567
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.