Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate presigner into nested package for consistency #502

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Generate presigner into nested package for consistency #502

merged 3 commits into from
Jan 20, 2022

Conversation

kggilmer
Copy link
Contributor

Issue #

N/A

Description of changes

  • Update presiger codegen to generate into nested package to be consistent with paginators (and probably waiters)
  • Update file to use plural form for same reasons

Testing Done

  • Genereate services with presigners and ensure e2e tests continue to pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kggilmer kggilmer requested a review from a team as a code owner January 14, 2022 01:04
@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-refactor-presigner-packagename

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-refactor-presigner-packagename

aajtodd
aajtodd approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to mark it as a breaking change when you merge

@kggilmer kggilmer merged commit 4b9b32c into main Jan 20, 2022
@kggilmer kggilmer deleted the refactor-presigner-packagename branch January 20, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@aajtodd aajtodd aajtodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kggilmer @aajtodd @ianbotsf