Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codegen to generate base exception rather than UnknownServiceErrorException #484

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Update codegen to generate base exception rather than UnknownServiceErrorException #484

merged 5 commits into from
Jan 5, 2022
+130 −20

Conversation

kggilmer
Copy link
Contributor

Issue #

#458

Description of changes

Additional Testing

  • Manually verify S3 exception codegen
  • Verify all services compile locally after change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kggilmer kggilmer requested a review from a team as a code owner December 31, 2021 00:24
@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-fix-error-parse-exception

aajtodd
aajtodd requested changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the exception from the runtime as well (I don't believe it is used anywhere else, maybe do a quick grep to verify).

ianbotsf
ianbotsf approved these changes Jan 3, 2022
View reviewed changes
...src/test/kotlin/aws/sdk/kotlin/codegen/protocols/core/AwsHttpBindingProtocolGeneratorTest.kt Outdated
Comment on lines 78 to 79
override val defaultTimestampFormat: TimestampFormatTrait.Format
get() = TODO("Unneeded for test")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: I think we should reserve TODO for things that we honestly believe need to be done in the future. If we don't intend to implement unused interface members, I suggest using something with clearer semantics like fail or throw IllegalStateException.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-error-parse-exception

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-error-parse-exception

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-error-parse-exception

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-error-parse-exception

@kggilmer kggilmer merged commit 704ea10 into main Jan 5, 2022
@kggilmer kggilmer deleted the fix-error-parse-exception branch January 5, 2022 00:00
@aajtodd aajtodd mentioned this pull request Jan 18, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@aajtodd aajtodd aajtodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kggilmer @aajtodd @ianbotsf