Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "transfer-encoding" header from responses #442

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

bnusunny
Copy link
Contributor

@bnusunny bnusunny commented Apr 19, 2024

Description of changes:

This change removes "transfer-encoding" http header from web app response. This resolves an issue that sam local start-api fails to handle the chunked response from SpringBoot.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bnusunny bnusunny requested a review from mbfreder April 19, 2024 09:03
@bnusunny bnusunny changed the title Remove hop-by-hop headers from requests and responses Remove hop-by-hop headers from responses Apr 19, 2024
src/lib.rs Outdated Show resolved Hide resolved
@bnusunny bnusunny changed the title Remove hop-by-hop headers from responses [WIP] Remove hop-by-hop headers from responses Apr 19, 2024
@bnusunny
Copy link
Contributor Author

I need to double check if this is the right place to remove these headers. At least 'transfer-encoding' is used in lambda-http crate to handle response body.

@bnusunny bnusunny changed the title [WIP] Remove hop-by-hop headers from responses [WIP] Remove "transfer-encoding" header from responses Apr 20, 2024
@bnusunny bnusunny changed the title [WIP] Remove "transfer-encoding" header from responses Remove "transfer-encoding" header from responses Apr 20, 2024
@bnusunny
Copy link
Contributor Author

I confirmed 'transfer-encoding' is not used in lambda-http crate to handle response body.

@bnusunny bnusunny merged commit 035659c into main Apr 20, 2024
23 checks passed
@bnusunny bnusunny deleted the remote-hop-by-hop-headers branch April 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants