Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add URL query if it's not empty #933

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

RaeesBhatti
Copy link
Contributor

📬 Issue #, if available:

✍️ Description of changes:
In the current state, the runtime adds a ? to every request URL even if the query was not set. This change fixes that behavior for AWS API Gateway V2 requests.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@calavera calavera merged commit 19c190d into awslabs:main Oct 18, 2024
5 checks passed
@RaeesBhatti RaeesBhatti deleted the patch-1 branch October 18, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants