Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on the CloudTrail event #909

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

martinjlowm
Copy link
Contributor

📬 Issue #, if available:
N/A

✍️ Description of changes:
The initial contribution of the CloudTrail event was not complete, but rather constructed from a handful of event examples. The structure is documented at:

which indicates a number of optional fields and more fields that weren't already covered.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

The initial contribution of the CloudTrail event was not complete, but rather
constructed from a handful of event examples. The structure is documented at
https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-event-reference-user-identity.html
which covers a number of optional fields and fields that are not already
covered.
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we have any tests for these events. Can you add some like we have in other event modules?

@martinjlowm martinjlowm requested a review from calavera July 10, 2024 19:44
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making these improvements!

@calavera calavera merged commit 309e3ab into awslabs:main Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants