Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add an example for using the anyhow crate #904

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

taiki45
Copy link
Contributor

@taiki45 taiki45 commented Jul 1, 2024

📬 Issue #, if available:

Not resolve but related with #901

✍️ Description of changes:

v0.12.0 has breaking changes for users who use external error types like anyhow::Error. This PR brings documentation that makes it easier for both existing and new users to write lambda functions with crates like anyhow.

While I believe a fundamental solution to eliminate the need for conversion from external error types to common types should be addressed in #901, this PR aims to provide documentation support for existing users encountering changes in v0.12.0 and for new users of the library who might struggle with simply using anyhow::Result. I think it's important to follow up with documentation to assist these users.

🔏 By submitting this pull request
Both in the root and the example root:

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@calavera calavera merged commit c4594f7 into awslabs:main Jul 1, 2024
5 checks passed
@taiki45 taiki45 deleted the example-anyhow branch July 1, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants