Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/documentdb #742

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Hotfix/documentdb #742

merged 3 commits into from
Dec 1, 2023

Conversation

nichmorgan
Copy link
Contributor

@nichmorgan nichmorgan commented Nov 30, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

Correction of fields:

Include serde_default in optional fields that do not already have it.

Convert ls_id to Option
and cluster_time to Option as it is only available from version 4.0 onwards.

Update Event:
Include the update_description field.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

nichmorgan and others added 3 commits November 30, 2023 15:05
@nichmorgan
Fix field types:
395f39c 
- ls_nd must be an AnyDocument
- cluster_time must be optional, because it's new at version 4.0
Fields bug fix
ceb1c31
Merge branch 'main' into hotfix/documentdb
0d6b418
calavera
calavera approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@calavera calavera merged commit 1e4e203 into awslabs:main Dec 1, 2023
5 checks passed
@nichmorgan nichmorgan deleted the hotfix/documentdb branch December 1, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nichmorgan @calavera