Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: update hyper/http #740

Closed
wants to merge 2 commits into from
Closed

Conversation

simbleau
Copy link
Contributor

@simbleau simbleau commented Nov 29, 2023

Issue #, if available:
#737

Description of changes:
Updates a good bit of #737 -
Hit a snag, though. I don't fully understand hyper::Client and how it worked, likewise for Connectors, and it seems they were removed with the update to 1.0 with almost 0 documentation in the hyper/http CHANGELOGs.

This means attention is needed in lambda-runtime-api-client/lib.rs.
Perhaps @calavera is able to update that file?

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@simbleau
Copy link
Contributor Author

I've put up the bat symbol, an issue to hyper, to help speed things up.

@calavera
Copy link
Contributor

Thanks for starting this PR! I believe some of the high level components were moved to hyper-util and http-body-util from what I read in https://tokio.rs/blog/2023-11-27-announcing-axum-0-7-0

Since you started this already, it might be good to let you continue, unless you're stuck with something. You've already made more progress than I ever did when I looked at it a couple of weeks ago. Maybe @jonhoo can point you to areas he discovered when he tried too.

@simbleau
Copy link
Contributor Author

simbleau commented Nov 29, 2023

I was able to go a bit further after some clarity in https://hyper.rs/guides/1/upgrading/ and hyperium/hyper#3450.

Now lambda-runtime-api-client has no compile issues, and should generally serve as a guide on how to upgrade the rest.

I didn't intend to get this PR across the finish line myself, but I wanted to contribute.

@calavera It would be better if you took a look at how I updated the lambda-runtime-api-client, made sure there were no issues with the upgrades, and then tried to take a stab at lambda-runtime and lambda-extension which still have compile issues.

@calavera
Copy link
Contributor

calavera commented Dec 9, 2023

Closing this PR in favor of #749. Thanks a lot for your help!

@calavera calavera closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants